[MIRROR] [MIRROR] Better UI for heretic research [MDB IGNORE] #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#3413
Original PR: tgstation/tgstation#84363
About The Pull Request
A redo of #82679. A new UI for heretic research that organizes the nodes into tiers and gives them icons.
This is done by a few new variables for the knowledge datum, which hold the level it should be located at, and the icon it should have. If not specified, an icon is automatically generated for summons, spells, eldritch marks and ascensions. You may also only specify some of the parameters, in which case the rest is generated automatically.
Also three notable related changes:
movementargument and casts it into boolean on its own, so that we can pass itBooleanLikeScreenshots:
Older design screenshots (for older comment context):
Why It's Good For The Game
Pretty UI is good. Makes the research interface less confusing by at least showing what nodes are more advanced, and will lead to ascension, and giving a rough idea of the relationship of the paths.
Changelog
🆑
add: Added a new UI for heretic research.
/:cl: